-
Notifications
You must be signed in to change notification settings - Fork 13
chore(React19): Allow support for React 19 #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
02ef1ac to
70430ac
Compare
| "@testing-library/user-event": "14.4.3", | ||
| "@testing-library/jest-dom": "5.16.5", | ||
| "@testing-library/dom": "9.0.0", | ||
| "@testing-library/dom": "^10.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These support 19
kmcfaul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Yes the ReactCurrentDispatcher error is expected when trying to build the docs with React 19 due to the outdated dep in the framework. As long as the extension continues to build with React 18, and the module can build with React 19 aside from the docs I think it's good to go.
|
🎉 This PR is included in version 6.2.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Works with 18 as a peer dependency.
With 19, get some problems due to docs framework: