Skip to content

Conversation

@andrew-ronaldson
Copy link
Contributor

@andrew-ronaldson andrew-ronaldson commented Dec 19, 2024

Closes #74
Their shouldn't be an underline on the vertical tabs

Their shouldn't be an underline on the vertical tabs
@patternfly-build
Copy link

patternfly-build commented Dec 19, 2024

@christianvogt
Copy link

@andrew-ronaldson along with #73 and the removal of the underline, the only hover treatment is the blue color. Not sure if it was also intended to keep the background hover treatment.
image

@andrew-ronaldson
Copy link
Contributor Author

Thanks @christianvogt
I'll look at this with @evwilkin to resolve.

@nicolethoen
Copy link
Contributor

@andrew-ronaldson could you make this same change on this line so the change is reflected in the docs?

And if we want to make a change to the color of the background of the nav item on hover, that change will need to be made in two spots as well.

@andrew-ronaldson
Copy link
Contributor Author

Approved

@nicolethoen nicolethoen merged commit 7738f40 into main Jan 16, 2025
5 checks passed
@github-actions
Copy link

🎉 This PR is included in version 6.1.0-prerelease.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VerticalTabs component links have text decoration set to underline

5 participants