feat(CC-batch-4): added batch 4 #11830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-11830.surge.sh A11y report: https://patternfly-react-pr-11830-a11y.surge.sh Preview: https://pf-react-pr-11830.surge.sh A11y report: https://pf-react-pr-11830-a11y.surge.sh |
mattnolting
force-pushed
the
feat-CC-batch-4
branch
2 times, most recently
from
d082d8c to
9e4b7e6
Compare
nicolethoen
requested changes
May 28, 2025
packages/code-connect/components/DataList/DataListRow.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/DescriptionList/DescriptionListItem.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/DescriptionList/TermLabel.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/DualListSelector/DualListHeader.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/DualListSelector/DualListItemBaseComponent.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/DualListSelector/DualListItemTypes.figma.tsx
Outdated
Show resolved
Hide resolved
kmcfaul
reviewed
May 29, 2025
packages/code-connect/components/DataList/DataListRow.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/DataList/DataListRow.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/DescriptionList/DescriptionListItem.figma.tsx
Show resolved
Hide resolved
packages/code-connect/components/DescriptionList/DescriptionListItem.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/Drawer/DrawerContent.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/DualListSelector/DualListItemBaseComponent.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/DualListSelector/DualListItemTree.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/DualListSelector/DualListItemTypes.figma.tsx
Outdated
Show resolved
Hide resolved
mattnolting
force-pushed
the
feat-CC-batch-4
branch
from
e62095b to
226060c
Compare
nicolethoen
requested changes
Jun 12, 2025
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
There are lots of outstanding comments in this PR. i will wait to finish rereviewing it
packages/code-connect/components/DataList/DataListRow.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/DataList/DataListRow.figma.tsx
Outdated
Show resolved
Hide resolved
mattnolting
force-pushed
the
feat-CC-batch-4
branch
from
ba2bde7 to
251907d
Compare
mattnolting
commented
Jul 10, 2025
packages/code-connect/components/DataList/_2BaseComponentsControlCell.figma.tsx
Outdated
Show resolved
Hide resolved
mattnolting
commented
Jul 10, 2025
packages/code-connect/components/DataList/_2BaseComponentsContentCell.figma.tsx
Outdated
Show resolved
Hide resolved
mattnolting
commented
Jul 15, 2025
packages/code-connect/components/DescriptionList/DescriptionListInCard.figma.tsx
Outdated
Show resolved
Hide resolved
mattnolting
commented
Jul 15, 2025
mattnolting
commented
Jul 15, 2025
mattnolting
commented
Jul 18, 2025
Contributor
Author
|
Need to remove Banner - breadcrumb - codeblock - codeEditor These are all in Batch-3 |
mattnolting
commented
Jul 29, 2025
packages/code-connect/components/DescriptionList/DescriptionListInCard.figma.tsx
Outdated
Show resolved
Hide resolved
mattnolting
commented
Jul 29, 2025
packages/code-connect/components/DescriptionList/TermLabel.figma.tsx
Outdated
Show resolved
Hide resolved
mattnolting
commented
Jul 29, 2025
packages/code-connect/components/DescriptionList/TermLabel.figma.tsx
Outdated
Show resolved
Hide resolved
mattnolting
commented
Jul 29, 2025
packages/code-connect/components/DualListSelector/DualListItemTypes.figma.tsx
Outdated
Show resolved
Hide resolved
mattnolting
commented
Jul 29, 2025
packages/code-connect/components/DualListSelector/DualListItemTree.figma.tsx
Outdated
Show resolved
Hide resolved
mattnolting
force-pushed
the
feat-CC-batch-4
branch
from
d31885d to
e1e4f71
Compare
mattnolting
commented
Aug 12, 2025
packages/code-connect/components/DataList/_1BuildItYourselfClickableRows.figma.tsx
Outdated
Show resolved
Hide resolved
kmcfaul
approved these changes
Aug 12, 2025
mattnolting
force-pushed
the
feat-CC-batch-4
branch
from
e1e4f71 to
fe176ef
Compare
mattnolting
force-pushed
the
feat-CC-batch-4
branch
from
5c5b058 to
9b04888
Compare
nicolethoen
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #11624
Included components:
Data ListComponent tracker
Figma preview
Resources: