-
Notifications
You must be signed in to change notification settings - Fork 11
fix(API): address issues with text API in monorepos #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9fd87fb
fix(API): address issues with text API in monorepos
wise-king-sullyman d75e164
Prevent the api index from being bundled, which can cause it to be ou…
wise-king-sullyman 7b27a98
Update to output the apiIndex to the user specified output directory
wise-king-sullyman 9bced60
update api routes to fetch the apiIndex at runtime rather than import it
wise-king-sullyman 06a90f4
fix fetching the apiIndex when running the dev server
wise-king-sullyman 76e5270
fix unit tests
wise-king-sullyman fc8173c
fix lint errors
wise-king-sullyman cd5c2a0
Remove custom outputDir pathing now that we're fetching the apiIndex at
wise-king-sullyman 062ae90
remove unused imports
wise-king-sullyman f41a39e
improve readme clarity
wise-king-sullyman 43c2194
add error handling for the apiIndex copy operation
wise-king-sullyman 8e9d674
Improve typing for the apiIndex fetch util
wise-king-sullyman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,3 +34,7 @@ src/apiIndex.json | |
| textContent/*.mdx | ||
|
|
||
| coverage/ | ||
|
|
||
| .wrangler/ | ||
|
|
||
| temp | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: patternfly/patternfly-doc-core
Length of output: 761
🏁 Script executed:
Repository: patternfly/patternfly-doc-core
Length of output: 1997
🏁 Script executed:
Repository: patternfly/patternfly-doc-core
Length of output: 1180
Pass the build output directory explicitly to Wrangler.
The deployment command executes
wrangler pages deploywithout specifying which directory to deploy. Since docs are built toabsoluteOutputDir(derived fromconfig.outputDir), but this path is not passed to the deploy function, the deploy command needs to be updated to:Or the
deploy()function should receiveabsoluteOutputDiras a parameter and pass it to the wrangler command. Without this, Wrangler may deploy from the wrong directory or fail if the consumer'swrangler.tomlis not correctly configured.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intended, we want the deploy dir to come from the wrangler config file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wise-king-sullyman, understood! Using the wrangler.toml configuration for the deployment directory is a valid approach and keeps the deployment configuration centralized. Thank you for clarifying the intent.