Upgrade silverstripe-gridfieldlimititems to SS4 with enforced limit#8
Open
MasseyIsaako wants to merge 8 commits intopatricknelson:masterfrom
Open
Conversation
MasseyIsaako
force-pushed
the
upgrade/ss4-with-enforced-limit
branch
from
ee65708 to
e708f67
Compare
MasseyIsaako
changed the title
MasseyIsaako
changed the title
adunn49
reviewed
Oct 16, 2018
| @@ -1,12 +1,25 @@ | |||
| <?php | |||
|
|
|||
| namespace MBIE\GridFieldLimitRelationEditor; | |||
There was a problem hiding this comment.
The SS4 docs suggest a namespace root of vendor\package so I'd suggest we change the namespace on this file to something like PatrickNelson\GridFieldLimitItems'.
MasseyIsaako
force-pushed
the
upgrade/ss4-with-enforced-limit
branch
from
e708f67 to
718b806
Compare
adunn49
reviewed
Oct 17, 2018
| // Not compatible with paginator. | ||
| if ($gridField->getConfig()->getComponentByType('GridFieldPaginator')) { | ||
| if ($gridField->getConfig()->getComponentByType(GridFieldPaginator::class)) { | ||
| $this->debug('GridFieldLimitItems is not compatible with GridFieldPaginator.'); |
There was a problem hiding this comment.
As discussed, we'll need to handle these debug messages - using LoggingInterface instead of SS_Log
MasseyIsaako
force-pushed
the
upgrade/ss4-with-enforced-limit
branch
from
dbcd39c to
6067e37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.