Feature/pu 2/slider #117
Open
Feature/pu 2/slider #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 21, 2022 08:40
votoan410
reviewed
Sep 21, 2022
| /** for user to pass in right/max value when range is enable */ | ||
| rangeSliderRightValue?: number; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
before the component declaration, you can add the description about the component and how to import it, the description will be rendered on the storybook page before the "Story Source" section. For example in the icon component:
/**
- An Icon is a symbol that helps user understand what does the content do.
-
- import {Icon} from 'pat-ui'
-
*/
Collaborator
There was a problem hiding this comment.
Also, you want to merge to master branch not production branch I believe.
Collaborator
Author
There was a problem hiding this comment.
humm, i think after Patrick approves, then i can merge to master branch :), but thanks though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://yuhan.atlassian.net/jira/software/projects/PUI/boards/2?selectedIssue=PUI-2
finished Slider Component with storybook & unit test