Closed
Conversation
stephanoskomnenos
force-pushed
the
infer-expand
branch
from
7bd9eeb to
4c4340b
Compare
Owner
|
This is a very large PR. How does it compare to the approach in #135 ? |
Author
That one doesn't support nested expand and automatic type infer from |
Owner
|
Hey @stephanoskomnenos, thanks for the PR! I think #135 solves this quite elegantly and handles nested relations. Since this touches thousands of lines and has no detail, it's very hard to review. I'm going to close it but if you think there's a reason this should be considered over the other approach, let me know and also provide some context about how it works. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes expand types inferable from
expandoption string. It support multiple levels and multiple relations.