Skip to content

TDVP small refactor#229

Merged
kbidzhiev merged 4 commits intomainfrom
kb/small_refactor
Mar 13, 2026
Merged

TDVP small refactor#229
kbidzhiev merged 4 commits intomainfrom
kb/small_refactor

Conversation

@kbidzhiev
Copy link
Contributor

@kbidzhiev kbidzhiev commented Mar 12, 2026

I've simplified logic in TDVP, making a first step toward generalisation.

  • _swipe_direction, _sweep_index and _timestep_index renamed because they are internal variables of the class
  • _swipe_direction, _sweep_index and _timestep_index have default values and its reflected in a default constructor
  • Sweep direction and MPS node indexing are logically not coupled, its now reflected in the code

@kbidzhiev kbidzhiev marked this pull request as ready for review March 12, 2026 11:09
@kbidzhiev kbidzhiev requested review from a-quelle-pasqal, elmerhej and murogrande and removed request for a-quelle-pasqal, elmerhej and murogrande March 12, 2026 11:17
@kbidzhiev kbidzhiev changed the title Kb/small refactor TDVP small refactor Mar 13, 2026
Copy link
Contributor

@a-quelle-pasqal a-quelle-pasqal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbidzhiev kbidzhiev merged commit 8011513 into main Mar 13, 2026
15 of 16 checks passed
@kbidzhiev kbidzhiev deleted the kb/small_refactor branch March 13, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants