Adding restart for non converging Krylov algorithm#223
Merged
a-quelle-pasqal merged 26 commits intomainfrom Mar 9, 2026
Merged
Adding restart for non converging Krylov algorithm#223a-quelle-pasqal merged 26 commits intomainfrom
a-quelle-pasqal merged 26 commits intomainfrom
Conversation
kbidzhiev
commented
Feb 26, 2026
a-quelle-pasqal
requested changes
Mar 2, 2026
Contributor
a-quelle-pasqal
left a comment
There was a problem hiding this comment.
Please also add the literature, I'm especially interested in the justification for
resid = (beta * y[-1]).abs() # == norm(op(ritz_vec) - ritz_value * ritz_vec)
elmerhej
reviewed
Mar 2, 2026
elmerhej
reviewed
Mar 2, 2026
Contributor
Author
see Saad (1), Prop. 6.8 (Ch. 6, p. 131). (1) Numerical Methods for Large Eigenvalue Problems, Y. Saad. |
elmerhej
previously approved these changes
Mar 2, 2026
Contributor
Author
done in the comments in the code and in the head of the file |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Lanczos implementation to use a residual-minimizing restart strategy for DMRG only. After each iteration the algorithm evaluates the residuals of the candidate vectors, selects the vector with the smallest residual, and restarts the search from that vector.
What changed
exhaustive guide to numerical errors etc in Lanczos algo
Lectures on Lanczos with detail study of residual
https://www.stat.uchicago.edu/~lekheng/courses/302/demmel/demmch7.pdf