-
Notifications
You must be signed in to change notification settings - Fork 528
Built-in am18x5 driver in DVOS #2885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
system/inc/system_exrtc.h
Outdated
| extern "C" { | ||
| #endif // __cplusplus | ||
|
|
||
| int system_external_rtc_set_config(const particle::hal_am18x5_config_t* conf, void* reserved); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be under HAL. We have for example sleep in both system and HAL, but the reason to have system-level APIs for it is that it deals with connectivity (network/cloud) and other somewhat higher level things. here you are just configuring/querying a peripheral albeit external one.
0c0beb6 to
896ec3d
Compare
|
Should I expect this PR to work on Muon? I am running the test app and I see I added logging to fwiw this is logged on boot |
Were you using MSoM + Muon? Just make sure the pins are configured as: STARTUP(
#if PLATFORM_ID == PLATFORM_MSOM
System.enableFeature(FEATURE_ETHERNET_DETECTION);
if_wiznet_pin_remap remap = {};
remap.base.type = IF_WIZNET_DRIVER_SPECIFIC_PIN_REMAP;
remap.cs_pin = A3;
remap.reset_pin = PIN_INVALID;
remap.int_pin = A4;
if_request(nullptr, IF_REQ_DRIVER_SPECIFIC, &remap, sizeof(remap), nullptr);
SystemPowerConfiguration powerConfig = System.getPowerConfiguration();
powerConfig.auxiliaryPowerControlPin(D7).interruptPin(A7);
System.setPowerConfiguration(powerConfig);
#endif
);Also, from your log, the external RTC wasn't even ticking. |
Note: This PR makes the AM18x5 driver generally available for all Particle platforms, except for B-series due to flash size constraint.
Features
Known issues
Example app
Completeness