-
-
Notifications
You must be signed in to change notification settings - Fork 148
Added forecast alerts #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added forecast alerts #1394
Conversation
WalkthroughA new alert type, Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant HTTP_Handler as HTTP Handler (`post`)
participant AlertsModule as Alerts Module
Client->>HTTP_Handler: POST /alerts (with alert type)
HTTP_Handler->>AlertsModule: load(alert_type)
alt alert_type is Threshold
AlertsModule-->>HTTP_Handler: Success
HTTP_Handler-->>Client: 200 OK
else alert_type is Anomaly or Forecast
AlertsModule-->>HTTP_Handler: AlertError::NotPresentInOSS(type)
HTTP_Handler-->>Client: 400 Bad Request + error message
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Suggested labels
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (3)📓 Common learnings
src/alerts/mod.rs (1)Learnt from: nikhilsinhaparseable src/handlers/http/alerts.rs (1)Learnt from: nikhilsinhaparseable ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
🔇 Additional comments (4)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fixes #XXXX.
Description
This PR has:
Summary by CodeRabbit
New Features
Bug Fixes
Refactor