-
-
Notifications
You must be signed in to change notification settings - Fork 145
chore: simplify schema creation from storage #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: simplify schema creation from storage #1368
Conversation
WalkthroughThe changes refactor schema creation logic by removing separate methods for creating schemas from ingestor and querier sources, consolidating them into a single method that fetches and stores schemas using a unified approach. Related function calls and helpers are updated or removed in accordance with this new schema retrieval strategy. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant ObjectStorage
participant fetch_schema
Caller->>ObjectStorage: create_schema_from_storage(stream_name)
ObjectStorage->>fetch_schema: fetch_schema(stream_name)
fetch_schema-->>ObjectStorage: Schema object
ObjectStorage->>ObjectStorage: Serialize schema, store under schema path
ObjectStorage-->>Caller: Stored schema bytes
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
remove functions that creates schema from ingestors and queriers separately reused function `fetch_schema` that fetches all schema files and merges the schemas into one this ensures the schema is always the latest
8eb4934
to
29315f2
Compare
remove functions that creates schema from ingestors and queriers separately
reuse function
fetch_schema
that fetches all schema files and merges the schemas into onethis ensures the schema is always the latest
Summary by CodeRabbit