chore: simplify schema creation from storage

[nikhilsinhaparseable]

remove functions that creates schema from ingestors and queriers separately
reuse function fetch_schema that fetches all schema files and merges the schemas into one

this ensures the schema is always the latest

Summary by CodeRabbit

• Refactor
  • Streamlined schema creation by consolidating multiple schema retrieval methods into a single process, now always sourcing schemas directly from storage.
  • Updated internal logic to use the new unified schema retrieval approach, removing fallback mechanisms and redundant methods.

[coderabbitai]

Walkthrough

The changes refactor schema creation logic by removing separate methods for creating schemas from ingestor and querier sources, consolidating them into a single method that fetches and stores schemas using a unified approach. Related function calls and helpers are updated or removed in accordance with this new schema retrieval strategy.

Changes

File(s)	Change Summary
src/migration/mod.rs	Removed the fetch_or_create_schema function and updated migration_stream to call create_schema_from_storage directly.
src/parseable/mod.rs	Updated to use create_schema_from_storage instead of create_schema_from_ingestor in schema creation logic.
src/storage/object_storage.rs	Removed create_schema_from_querier and create_schema_from_ingestor; added and implemented create_schema_from_storage.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant ObjectStorage
    participant fetch_schema

    Caller->>ObjectStorage: create_schema_from_storage(stream_name)
    ObjectStorage->>fetch_schema: fetch_schema(stream_name)
    fetch_schema-->>ObjectStorage: Schema object
    ObjectStorage->>ObjectStorage: Serialize schema, store under schema path
    ObjectStorage-->>Caller: Stored schema bytes

Loading

Suggested labels

for next release

Suggested reviewers

• de-sh

Poem

A hop, a skip, a schema hop,
No more ingestor, no more swap!
One method now, so neat and bright,
Fetches schemas left and right.
With every change, the code grows clean,
A rabbit’s joy—so swift, so keen! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8eb4934 and 29315f2.

📒 Files selected for processing (3)

• src/migration/mod.rs (1 hunks)
• src/parseable/mod.rs (1 hunks)
• src/storage/object_storage.rs (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

• src/parseable/mod.rs
• src/migration/mod.rs
• src/storage/object_storage.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

• GitHub Check: Build Default x86_64-unknown-linux-gnu
• GitHub Check: Build Default x86_64-apple-darwin
• GitHub Check: Build Kafka aarch64-apple-darwin
• GitHub Check: Build Kafka x86_64-unknown-linux-gnu
• GitHub Check: Build Default aarch64-unknown-linux-gnu
• GitHub Check: Quest Smoke and Load Tests for Standalone deployments
• GitHub Check: Build Default aarch64-apple-darwin
• GitHub Check: Quest Smoke and Load Tests for Distributed deployments
• GitHub Check: coverage

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.