Open
Conversation
|
This LGTM. However @alexxxkny given the recent discussions as well as the WFC vote regarding unifying address in the ecosystem, having your own SS58 prefix would not be advised. Tagging here @jak-pan who has been leading this initiative. |
Contributor
Author
|
Hello @bkchr @SBalaguer ! We are informed about coming migration to Unified Address Format and looking forward to join. But until migration officially started and wallets/cexes applied corresponding changes we would love to conform to the current process and make this PR merged. Could we please get a review here? |
Contributor
Author
|
What a timings :) |
Contributor
|
The WFC passed and the process started, so if you don't have running network the recommended prefix is for everybody even if you are conforming to old process is 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.