refactor: move to kraken #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- using kraken instead of coindesk
| (s/defn get-btc-usd-price :- s/Num | ||
| [http :- schemas.types/HttpComponent] | ||
| (->> {:url "https://api.coindesk.com/v1/bpi/currentprice.json" | ||
| (->> {:url "https://api.kraken.com/0/public/Ticker?pair=XBTUSD" |
Member
There was a problem hiding this comment.
Isn't pair BTCUSD that we are interested?
Member
There was a problem hiding this comment.
Replying myself:
XBT and BTC are two different ticker symbols for Bitcoin. They are both in use and there is no difference between them. The BTC abbreviation was created by the Bitcoin community, and the XBT acronym was introduced by ISO as the international Bitcoin symbol.
But I think for the sake of clarity I would stick with BTCUSD
WDYT?
Member
Author
There was a problem hiding this comment.
Great! The only problem with that is: even using BTCUSD on the response it will return with XXBTZUSD.
Member
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to refactor boilerplate: