Skip to content

Fixes copy failure when accessing Parca UI via IP address #6050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes copy failure when accessing Parca UI via IP address #6050

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60c77d4
Fixes copy failure when accessing Parca UI via IP address
Haoning-Sun Nov 12, 2025
c3d7ea7
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion ui/packages/shared/profile/src/ProfileFlameGraph/FlameGraphArrow/ContextMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,40 @@
return isGraphTooltipDocked ? setIsDocked(false) : setIsDocked(true);
};
const handleCopyItem = (text: string): void => {
void navigator.clipboard.writeText(text);
if (navigator.clipboard?.writeText) {

Check failure on line 111 in ui/packages/shared/profile/src/ProfileFlameGraph/FlameGraphArrow/ContextMenu.tsx

View workflow job for this annotation

GitHub Actions / UI Test and Lint 

Unexpected object value in conditional. The condition is always true
void navigator.clipboard.writeText(text).catch(() => {
// Fallback to legacy method if modern API fails
copyWithLegacyMethod(text);
});
} else {
// Use legacy method if modern API not available
copyWithLegacyMethod(text);
}
};

const copyWithLegacyMethod = (text: string): void => {
const textArea = document.createElement('textarea');
textArea.value = text;
document.body.appendChild(textArea);
textArea.focus();
textArea.select();

let successful = false;
try {
successful = document.execCommand('copy');
} catch {
// Copy failed
} finally {
document.body.removeChild(textArea);
}

if (!successful) {
alert(
'Copy failed. Please copy manually: ' +
text.substring(0, 100) +
(text.length > 100 ? '...' : '')
);
}
};

const functionName =
Expand Down
Loading