fix(mcp): include tool-host correlation context in errors#992
Open
Osraka wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve tool-host correlation context on MCP tool call results and include it in error messages.
run_tool_host_callalready creates a request id and receives the session execution id for the sandbox-backed tool-host call, butToolHostCallOutputonly carried the sandbox id back to the MCP layer. When a tool timed out, returned a non-zero status, or produced non-JSON output, the user-facing MCP error could not point directly at the execution/request that operators need for trace/log lookup.This keeps the existing behavior and error shape, but adds the request/execution ids to the context string used in MCP tool-host errors, for example:
failed in sandbox sbx-..., execution exe-..., request mcp-call-...Tests
cargo test -p centaur-api-server mcp::mcp_tests -- --nocapturecargo test -p centaur-session-runtime -- --nocapturecargo fmt --checkgit diff --check