[codex] sanitize tool analytics args#892
Open
EfeDurmaz16 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
centaur-toolsaudit argument capture by default so tool-call logs keep command shape/counts without raw payloadsCENTAUR_TOOL_ANALYTICS_ARGS_MODE(shape,raw,off) and surfacetool_args_redactedin vlogs resultsWhy
Tool shim analytics currently write raw CLI args into structured logs. Those args can include prompt text, JSON payloads, API key flags, auth headers, or raw tokens, which conflicts with the repo logging contract for secrets and auth material.
Validation
PYTHONPYCACHEPREFIX=/private/tmp/centaur-pycache /opt/homebrew/bin/python3.14 -m unittest test_install_tool_shims.pyPYTHONPYCACHEPREFIX=/private/tmp/centaur-pycache /opt/homebrew/bin/python3.14 -m py_compile services/sandbox/install_tool_shims.py services/sandbox/test_install_tool_shims.py tools/infra/vlogs/client.py tools/infra/vlogs/tests/test_client.pyUV_CACHE_DIR=/private/tmp/uv-cache PYTHONPYCACHEPREFIX=/private/tmp/centaur-pycache PYTHONPATH=tools/infra /Users/efebarandurmaz/.local/bin/uv run --no-editable --with pytest --with ruff --project tools/infra/vlogs python -m pytest tools/infra/vlogs/tests/test_client.pyUV_CACHE_DIR=/private/tmp/uv-cache /Users/efebarandurmaz/.local/bin/uv run --with ruff ruff check services/sandbox/install_tool_shims.py services/sandbox/test_install_tool_shims.py tools/infra/vlogs/client.py tools/infra/vlogs/tests/test_client.pygit diff --checkNotes
rawmode preserves the previous exact-argument behavior for deployments that intentionally want full args.just build-one sandbox; Docker reached OrbStack, but the local Docker install is missing the buildx component required for BuildKit.