docs: update Korean Book - #245
Open
EatChangmyeong wants to merge 2 commits into
Open
Conversation
Collaborator
|
Hmm, ko-book isn't actually served currently. |
Contributor
Author
|
@NoamDev Unfortunately we still have some more work before it can be released (especially adding mdbook-i18n-helpers). I believe @faiface will take care of updating the website when it's all done |
Collaborator
|
@EatChangmyeong |
Collaborator
|
@EatChangmyeong I suggest for this PR, we merge the book update only, and make another PR that adds the multilingual support + updates the website's build pipeline if necessary. Wdyt? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Korean Book now mentions the new
includeexpression.Additionally, both the English and Korean version now have links pointing to each other. What do you think about them?