fix: correct error message for merge_asof tolerance validation#66298
Open
muhamedfazalps wants to merge 1 commit into
Open
fix: correct error message for merge_asof tolerance validation#66298muhamedfazalps wants to merge 1 commit into
muhamedfazalps wants to merge 1 commit into
Conversation
The error message said 'tolerance must be positive' but the check allows tolerance=0 (exact-match-only), which is non-negative. Changed to 'tolerance must be non-negative' to match the actual behavior. Fixes pandas-dev#66289
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66289
The error message for invalid tolerance in
merge_asofsaid "tolerance must be positive" but the guard only rejects strictly negative values (< 0), meaningtolerance=0(exact-match-only) is valid and accepted.This changes the error message to "tolerance must be non-negative" to match the actual behavior.
---\n\nbuymeacoffee.com/muhamedfazalps