DEPR: Treat tuple keys consistently in Resampler.__getitem__#66270
Open
EsDeath-Boop wants to merge 1 commit into
Open
DEPR: Treat tuple keys consistently in Resampler.__getitem__#66270EsDeath-Boop wants to merge 1 commit into
EsDeath-Boop wants to merge 1 commit into
Conversation
71e7cdd to
d9d35a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66266.
Summary
Resampler.__getitem__currently treats tuple keys as a list of columnlabels. For example,
behaves like
instead of following
DataFrame.__getitem__semantics.This PR updates
Resampler.__getitem__so that tuple keys are forwardedto the underlying
DataFrameselection. As a result:MultiIndexcolumnsMultiIndexcolumns raiseKeyErrorTests
test_getitemto expect aKeyErrorfor tuple keys on regular columns.MultiIndexcolumns.