-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
DOC/ENH: Holiday exclusion argument #61600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sharkipelago
wants to merge
14
commits into
pandas-dev:main
Choose a base branch
from
sharkipelago:holiday-exclusion-argument
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f054afb
added exclude_dates argument and test for holiday class
sharkipelago 5a809e2
added entry on whatsnew
sharkipelago 891b442
Merge remote-tracking branch 'upstream/main' into holiday-exclusion-a…
sharkipelago aa08735
moved pull request to v3.0.0 whatsnew
sharkipelago f019a5c
updated exclude_dates to be [Timestamp] in constructor
sharkipelago bdbb555
updated Holiday.dates() to use difference method
sharkipelago 5bca8c7
condensed type_checking import statement to 1 line
sharkipelago 655ca4e
switchted exclude_dates type from list[Timestamp] to DatetimeIndex
sharkipelago f46c394
raise ValueError if exclude_dates is not DatetimeIndex
sharkipelago 27cca3d
isinstance to check exclude_data
sharkipelago a9a745c
updated tests for DatetimeIndex type change
sharkipelago 7710e43
Merge remote-tracking branch 'upstream/main' into holiday-exclusion-a…
sharkipelago 5cfd599
added proper result-expected assertion pattern for tests
sharkipelago 2d9e4c5
removed redundant asserts
sharkipelago File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I also switch this to throw a
ValueError
on failing? Or would that be a separate PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A separate PR would be better, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this, should I open a new issue? Or just make another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just another PR is fine