Improvements to arguments, types with stubtest #1294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicdiridollou
commented
Jul 27, 2025
loicdiridollou
commented
Jul 27, 2025
loicdiridollou
commented
Jul 27, 2025
loicdiridollou
commented
Jul 27, 2025
loicdiridollou
commented
Jul 27, 2025
loicdiridollou
commented
Jul 27, 2025
loicdiridollou
commented
Jul 27, 2025
loicdiridollou
commented
Jul 27, 2025
loicdiridollou
commented
Jul 27, 2025
loicdiridollou
commented
Jul 27, 2025
loicdiridollou
commented
Jul 27, 2025
| @@ -53,7 +52,6 @@ class PeriodIndex(DatetimeIndexOpsMixin[pd.Period], PeriodIndexFieldOps): | |||
| def __rsub__( # pyright: ignore[reportIncompatibleMethodOverride] | |||
| self, other: NaTType | |||
| ) -> NaTType: ... | |||
| def __array__(self, dtype=...) -> np.ndarray: ... | |||
There was a problem hiding this comment.
Using parent definition.
loicdiridollou
commented
Jul 27, 2025
loicdiridollou
commented
Jul 27, 2025
loicdiridollou
commented
Jul 27, 2025
Dr-Irv
requested changes
Jul 28, 2025
pandas-stubs/core/frame.pyi
Outdated
| self, | ||
| func: AggFuncTypeBase | AggFuncTypeDictSeries, | ||
| func: AggFuncTypeBase | AggFuncTypeDictSeries = ..., |
There was a problem hiding this comment.
This is not valid. If you don't specify the value of func, an exception will be raised. Please revert.
Dr-Irv
reviewed
Jul 30, 2025
Co-authored-by: Irv Lustig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More improvements with the stubtest flagging some drift with pandas.
One point that was raised is the handling of deprecated items, maybe the other possibility than purely removing it from the stubs is to force the stubs to adopt the default value so that whatever the user is doing it won't allow any other behavior.
We need to see how much we can use stubtest, I don't see it being used in CI at the moment or anytime soon considering the mountain of work that it raises (mostly correctly but I have seen a few places where it is flagging things that are fine), there is also the problem of the
no_defaultthat pandas uses abundantly and which is hard to replicate in the stubs.assert_type()to assert the type of any return value