Skip to content

Conversation

@sfackler
Copy link
Member

@sfackler sfackler commented Aug 20, 2025

Before this PR

Only the server side (at codegen time) could pick if error parameters should use the old stringification approach or not.

After this PR

==COMMIT_MSG==
Added support for clients to opt-in to the new error parameter serialization format with the Accept-Conjure-Error-Parameter-Format header.
==COMMIT_MSG==

This should mirror the logic of the Java side: palantir/conjure-java#2588

@sfackler sfackler requested a review from a team August 20, 2025 20:19
@changelog-app
Copy link

changelog-app bot commented Aug 20, 2025

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

Added support for clients to opt-in to the new error parameter serialization format with the Accept-Conjure-Error-Parameter-Format header.

Check the box to generate changelog(s)

  • Generate changelog entry

@changelog-app
Copy link

changelog-app bot commented Aug 20, 2025

Successfully generated changelog entry!

What happened?

Your changelog entries have been stored in the database as part of our migration to ChangelogV3.

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.

}

impl ErrorConverter {
pub fn new(request_headers: &HeaderMap) -> Self {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to do some refactoring here since we don't have access to request headers after the handler runs.

@sfackler
Copy link
Member Author

Gonna hold off on this for a little until we're more confident that we want to commit to this on the Java side.

@stale
Copy link

stale bot commented Oct 18, 2025

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Oct 18, 2025
@sfackler sfackler removed the stale label Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants