-
Notifications
You must be signed in to change notification settings - Fork 14
Support the Accept-Conjure-Error-Parameter-Format header #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Generate changelog in
|
✅ Successfully generated changelog entry!What happened?Your changelog entries have been stored in the database as part of our migration to ChangelogV3. Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. |
| } | ||
|
|
||
| impl ErrorConverter { | ||
| pub fn new(request_headers: &HeaderMap) -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to do some refactoring here since we don't have access to request headers after the handler runs.
|
Gonna hold off on this for a little until we're more confident that we want to commit to this on the Java side. |
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
Before this PR
Only the server side (at codegen time) could pick if error parameters should use the old stringification approach or not.
After this PR
==COMMIT_MSG==
Added support for clients to opt-in to the new error parameter serialization format with the
Accept-Conjure-Error-Parameter-Formatheader.==COMMIT_MSG==
This should mirror the logic of the Java side: palantir/conjure-java#2588