use GradleExec#exec over ProviderFactory#exec #210
use GradleExec#exec over ProviderFactory#exec #210
GradleExec#exec over ProviderFactory#exec #210Conversation
Generate changelog in
|
✅ Successfully generated changelog entry!What happened?Your changelog entries have been stored in the database as part of our migration to ChangelogV3. Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. |
There was a problem hiding this comment.
🎉
I think this is good to go. Let's wait for a review from @CRogers before we merge.
| @Inject | ||
| protected abstract ProviderFactory getProviderFactory(); | ||
| @Nested | ||
| protected abstract GradleExec getGradleExec(); |
There was a problem hiding this comment.
Let's test that this compiles!
There was a problem hiding this comment.
should do thats how its used currently - https://github.com/palantir/gradle-utils/blob/develop/platform/src/main/java/com/palantir/platform/GradleOperatingSystem.java#L33
Co-authored-by: Kelvin Ou <58218998+kelvinou01@users.noreply.github.com>
|
marked as DNM until we settle how we want to handle errors (i.e palantir/gradle-utils#435) so we don't roll this out only to have to update later |
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
Before this PR
Had no errorprone to encourage the usage of
GradleExecAfter this PR
We now have an errorprone to force the usage of
GradleExec#execwith updatedREADMESee palantir/gradle-utils#435 (comment) for reference
==COMMIT_MSG==
use
GradleExec#execoverProviderFactory#exec==COMMIT_MSG==
Possible downsides?