Skip to content

Fix different python versions#12

Merged
johannes-moegerle merged 4 commits intomainfrom
improve_testing
Nov 26, 2025
Merged

Fix different python versions#12
johannes-moegerle merged 4 commits intomainfrom
improve_testing

Conversation

@johannes-moegerle
Copy link
Contributor

No description provided.

@johannes-moegerle johannes-moegerle changed the title Improve testing Fix different pthon versions Nov 26, 2025
@johannes-moegerle johannes-moegerle changed the title Fix different pthon versions Fix different python versions Nov 26, 2025
@johannes-moegerle johannes-moegerle marked this pull request as ready for review November 26, 2025 05:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Python version compatibility issues to enable support for Python 3.9 through 3.13. The changes primarily involve fixing type imports and adding runtime type checks.

  • Moved Self type import from typing to typing_extensions under TYPE_CHECKING blocks for compatibility with Python 3.9-3.10
  • Added isinstance checks in utils.py to handle cases where int types don't have the .is_integer() method
  • Updated CI workflow to test against all supported Python versions (3.9-3.13)

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/rydstate/angular/utils.py Added isinstance(arg, int) checks before calling .is_integer() to prevent AttributeError on int types
src/rydstate/angular/angular_state.py Moved Self import from typing to typing_extensions under TYPE_CHECKING for Python 3.9-3.10 compatibility
src/rydstate/angular/angular_ket.py Moved Self import from typing to typing_extensions under TYPE_CHECKING for Python 3.9-3.10 compatibility
src/rydstate/__init__.py Bumped version from 0.9.0 to 0.9.1 for this bug fix release
.github/workflows/testing.yml Added test matrix to validate compatibility across Python 3.9-3.13

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@johannes-moegerle johannes-moegerle merged commit f5a3f58 into main Nov 26, 2025
22 checks passed
@johannes-moegerle johannes-moegerle deleted the improve_testing branch November 26, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants