Merged
Conversation
72d966c to
a56d0e1
Compare
94766b5 to
ee75019
Compare
There was a problem hiding this comment.
Pull request overview
This PR addresses Python version compatibility issues to enable support for Python 3.9 through 3.13. The changes primarily involve fixing type imports and adding runtime type checks.
- Moved
Selftype import fromtypingtotyping_extensionsunder TYPE_CHECKING blocks for compatibility with Python 3.9-3.10 - Added
isinstancechecks inutils.pyto handle cases whereinttypes don't have the.is_integer()method - Updated CI workflow to test against all supported Python versions (3.9-3.13)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/rydstate/angular/utils.py |
Added isinstance(arg, int) checks before calling .is_integer() to prevent AttributeError on int types |
src/rydstate/angular/angular_state.py |
Moved Self import from typing to typing_extensions under TYPE_CHECKING for Python 3.9-3.10 compatibility |
src/rydstate/angular/angular_ket.py |
Moved Self import from typing to typing_extensions under TYPE_CHECKING for Python 3.9-3.10 compatibility |
src/rydstate/__init__.py |
Bumped version from 0.9.0 to 0.9.1 for this bug fix release |
.github/workflows/testing.yml |
Added test matrix to validate compatibility across Python 3.9-3.13 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ee75019 to
81d6cca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.