fix: drop the unused aprender-db dependency that breaks docs.rs downstream - #2468
Merged
Conversation
…rate
aprender-graph and aprender-rag each declared
trueno-db = { workspace = true } # package = "aprender-db"
as a NON-OPTIONAL dependency, and neither crate references it anywhere —
not in src/, not in tests/, benches/ or examples/:
$ grep -rl 'trueno_db\|aprender_db' crates/aprender-graph/src/ | wc -l
0
$ grep -rl 'trueno_db\|aprender_db' crates/aprender-rag/src/ | wc -l
0
aprender-db exists to provide Arrow/Parquet columnar storage. Both crates
already gate their real storage support behind a feature — aprender-graph
has `storage = ["dep:arrow", "dep:parquet"]` — so the mandatory edge bought
nothing that the feature did not already buy, and it could not be switched
off by a consumer who did not want Arrow.
Consumers who did not want Arrow got it anyway, and it broke them.
lexical-util <- lexical-core <- arrow-cast <- arrow <- aprender-db
`lexical-util 1.0.7` opens with `#![cfg_attr(docsrs, feature(doc_auto_cfg))]`.
That feature was removed in Rust 1.92 and merged into `doc_cfg`. docs.rs
builds on nightly with `docsrs` defined, so the crate stops compiling there:
error[E0557]: feature has been removed
--> lexical-util-1.0.7/src/lib.rs:83:29
= note: removed in 1.92.0; merged into `doc_cfg`
1.0.7 is that crate's latest release — there is nothing to bump to. The only
way out is to not be in its dependency graph.
paiml-mcp-agent-toolkit is: it takes aprender-graph non-optionally, so no
feature selection avoided the chain, and docs.rs has never built it — 3.30.0
and 3.29.0 both failed, and the crate is published with no API docs at all.
Two of the three paths into arrow were these unused edges.
Removing them, as pmat and aprender-viz both consume the crate
(`default-features = false`):
cargo check -p aprender-graph ok
cargo check -p aprender-rag ok
cargo test -p aprender-graph -p aprender-rag --lib 539 passed
cargo tree -p aprender-rag -i lexical-util no match
cargo tree -p aprender-graph --no-default-features -i lexical-util
no match
cargo tree -p aprender-graph --no-default-features -i arrow
no match
The other eight crates that name aprender-db do use it, and keep it.
Refs: paiml/paiml-mcp-agent-toolkit#988
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aprender-graphandaprender-rageach declaretrueno-db(packageaprender-db) as anon-optional dependency, and neither references it anywhere — not
src/, nottests/,benches/orexamples/.That unused edge drags the whole Arrow tree into every downstream crate:
lexical-util 1.0.7opens with#![cfg_attr(docsrs, feature(doc_auto_cfg))].doc_auto_cfgwas removed in Rust 1.92 and merged into
doc_cfg, so on docs.rs — nightly, withdocsrsdefined — it fails to compile:
1.0.7 is that crate's latest release. There is no version to bump to; the only fix is to leave
its dependency graph.
This has already broken a downstream crate.
pmattakesaprender-graphnon-optionally,so no feature selection avoided the chain — docs.rs has never built it (3.29.0 and 3.30.0 both
failed), and it is published on crates.io with no API documentation. Two of the three paths
into
arrowwere these unused edges.Both crates already gate their real storage support behind a feature (
aprender-graph'sstorage = ["dep:arrow", "dep:parquet"]), and bothpmatandaprender-vizconsumeaprender-graphwithdefault-features = false— so the mandatory edge bought nothing thefeature did not already buy, while making Arrow impossible to opt out of.
Verification
cargo check -p aprender-graphcargo check -p aprender-ragcargo test -p aprender-graph -p aprender-rag --libcargo tree -p aprender-rag -i lexical-utilcargo tree -p aprender-graph --no-default-features -i lexical-utilcargo tree -p aprender-graph --no-default-features -i arrow--no-default-featuresis exactly how both downstream consumers take it.The other eight crates that name
aprender-dbgenuinely use it and are untouched.Downstream issue: paiml/paiml-mcp-agent-toolkit#988
🤖 Generated with Claude Code