Express checkout #10
Express checkout #10
Conversation
| var initAfterPayExpress = function () { | ||
| var spinner = null; | ||
| var button = document.getElementById('afterpay_express_button'); | ||
| if (button.disabled == true) { |
There was a problem hiding this comment.
This is generally safer.
| if (button.disabled == true) { | |
| if (button && button.disabled == true) { |
| document.addEventListener('readystatechange', event => { | ||
| if (event.target.readyState === "interactive" && | ||
| typeof window.AfterPay !== 'undefined' && | ||
| typeof AfterPay.initializeForPopup != 'undefined' | ||
| ) { | ||
| initAfterPayExpress(); | ||
| } | ||
|
|
||
| // Double check | ||
| if (event.target.readyState === "complete" && | ||
| typeof window.AfterPay !== 'undefined' && | ||
| typeof AfterPay.initializeForPopup != 'undefined' && | ||
| document.getElementById('afterpay_express_button').disabled == true | ||
| ) { | ||
| initAfterPayExpress(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Just some suggestions.
This was done by Scott, he is a full stack eng and excels at front-end.
The button is disabled for a few seconds because the call stack has to loop through all the ready states when the real requirement is the button element and the Afterpay object. Therefore, we could possibly remove further checks and if we need to do so we can start checking from events DOMContentLoaded or load
I think passing jQuery as a param in an IIFE like Scott did is safer and allows avoiding having to loop through the documents ready states.
Additionally, the Ajax methods depend on jQuery therefore an exception would be thrown if jQuery is not in the window object.
No description provided.