Skip to content

Add rmdepcheck and fedora-review tests#3089

Open
LecrisUT wants to merge 1 commit intopackit:mainfrom
LecrisUT:feat/more-tests
Open

Add rmdepcheck and fedora-review tests#3089
LecrisUT wants to merge 1 commit intopackit:mainfrom
LecrisUT:feat/more-tests

Conversation

@LecrisUT
Copy link
Copy Markdown
Collaborator

@LecrisUT LecrisUT commented Apr 1, 2026

TODO:

  • Write new tests or update the old ones to cover new functionality.
  • Make the related tests compatible with packit's contexts
    • rmdepcheck
    • fedora-review

Merge after fedora-ci/rmdepcheck-pipeline#12

Also not sure how this would behave when run in prod when the corresponding tests are not yet enabled.

RELEASE NOTES BEGIN

Packit Fedora-CI now runs rmdepcheck and fedora-review tests on PRs.

RELEASE NOTES END

@LecrisUT LecrisUT requested a review from a team as a code owner April 1, 2026 12:26
@LecrisUT LecrisUT requested review from betulependule and removed request for a team April 1, 2026 12:26
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for rmdepcheck and fedora-review tests within the Fedora CI workflow by adding dedicated payload generation methods and updating the corresponding integration tests. The review feedback identifies several necessary corrections: the TMT plan names in the implementation should include a leading slash to maintain consistency with conventions and test expectations; the integration tests must be updated to expect the stg branch for the ref field to match the non-production environment logic; and the deployment check should be refactored to compare the enum member directly rather than its string name for improved robustness.

@centosinfra-prod-github-app
Copy link
Copy Markdown
Contributor

@centosinfra-prod-github-app
Copy link
Copy Markdown
Contributor

Signed-off-by: Cristian Le <git@lecris.dev>
@centosinfra-prod-github-app
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants