Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for rmdepcheck and fedora-review tests within the Fedora CI workflow by adding dedicated payload generation methods and updating the corresponding integration tests. The review feedback identifies several necessary corrections: the TMT plan names in the implementation should include a leading slash to maintain consistency with conventions and test expectations; the integration tests must be updated to expect the stg branch for the ref field to match the non-production environment logic; and the deployment check should be refactored to compare the enum member directly rather than its string name for improved robustness.
|
✔️ pre-commit SUCCESS in 1m 49s |
1cd596a to
23442ee
Compare
|
✔️ pre-commit SUCCESS in 1m 50s |
Signed-off-by: Cristian Le <git@lecris.dev>
23442ee to
8f75c98
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 48s |
TODO:
rmdepcheckfedora-reviewMerge after fedora-ci/rmdepcheck-pipeline#12
Also not sure how this would behave when run in
prodwhen the corresponding tests are not yet enabled.RELEASE NOTES BEGIN
Packit Fedora-CI now runs
rmdepcheckandfedora-reviewtests on PRs.RELEASE NOTES END