Support repository-specific rate limit checks for GithubApp/Tokman auth#2970
Conversation
majamassarini
requested review from
lbarcziova
and removed request for
a team
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a fallback mechanism for checking GitHub API rate limits, specifically for authentication methods like GithubApp and Tokman that require repository-specific context. The implementation is logical and correctly addresses the issue. My feedback focuses on improving the exception handling to be more specific, which will make the code more robust against unexpected errors.
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 49s |
majamassarini
force-pushed
the
check-rate-limit-fix
branch
from
6a765ac to
3eec7fc
Compare
|
✔️ pre-commit SUCCESS in 1m 47s |
majamassarini
force-pushed
the
check-rate-limit-fix
branch
from
3eec7fc to
9c2b14b
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 44s |
|
❌ pre-commit FAILURE in 1m 55s |
Co-authored-by: Nikola Forró <nforro@redhat.com>
majamassarini
force-pushed
the
check-rate-limit-fix
branch
from
52d72a0 to
ec04baf
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 47s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 45s |
3 participants
When using GithubApp or Tokman authentication, service.github returns None
because these methods require repository-specific instances.
Merge after packit/ogr#972