Fixes for bitbucket #627

prabhu · 2025-08-23T21:30:08Z

Fixes from gemini

Corrected Typos: The non-standard attribute is_case_sensitve has been corrected to the standard case_sensitive in both the namespace_definition and name_definition.
Required Components: The name_definition and version_definition now correctly state that they are "required" components.
Added Normalization Rules: To enforce the lowercasing requirement, normalization_rules have been added to the namespace_definition and name_definition.
Improved Descriptions: The native_name and note for the namespace have been updated to clarify its role for both Bitbucket Cloud (user/organization) and Server (project key). The version_definition note now explicitly warns against using mutable branch names.
Added Subpath and Qualifiers: The schema now includes a subpath_definition to support monorepos and a qualifiers_definition for the repository_url key, which is essential for self-hosted instances.
Enhanced Examples: The list of examples has been significantly expanded to cover various use cases, including packages identified by tags, those within a monorepo, and packages from self-hosted Bitbucket servers.

Signed-off-by: Prabhu Subramanian <[email protected]>

matt-phylum · 2025-08-25T12:27:08Z

types/bitbucket-definition.json

  },
  "version_definition": {
-    "note": "The version is a commit or tag.",
+    "requirement": "required",


It is unnecessarily restricting the usefulness of PURL to require a version here.

Agreed, @prabhu let's not make versions required

matt-phylum · 2025-08-25T12:27:46Z

types/bitbucket-definition.json

  "version_definition": {
-    "note": "The version is a commit or tag.",
+    "requirement": "required",
+    "note": "The version is an immutable commit hash (full or short) or a tag. Branch names (e.g., 'main') should not be used as they are mutable pointers.",


This doesn't work. Tags are also mutable. Software that works with PURLs cannot reasonably knowing whether a reference is intended to be mutable.

Makes sense. The original wording is simple enough and does not specify too little nor too much IMHO

matt-phylum · 2025-08-25T12:30:33Z

types/bitbucket-definition.json

+    "pkg:bitbucket/birkenfeld/pygments-main@244fd47e07d1014f0aed9c",
+    "pkg:bitbucket/atlassian/[email protected]",
+    "pkg:bitbucket/atlassian/[email protected]#packages/analytics",


None of these examples exist? Where did these new examples come from? The Pygments one might date back to when Bitbucket still supported Mercurial.

Good point, the pygments example should go since the project long moved to GitHub from Mercurial. ... for other examples too, let's use something real

pombredanne

@prabhu Thanks. Here are a few nitpickings for your consideration!

pombredanne · 2025-09-01T21:36:56Z

types/bitbucket-definition.json

-    "is_case_sensitve": false
+    "case_sensitive": false,
+    "normalization_rules": [
+      "It is not case sensitive and must be lowercased."


This is redundant with case_sensitive, so we would not add this IMHO

pombredanne · 2025-09-01T21:37:18Z

types/bitbucket-definition.json

+    "native_name": "user, organization, or project key",
+    "case_sensitive": false,
+    "normalization_rules": [
+      "It is not case sensitive and must be lowercased."


case_sensitive implies this alright

pombredanne · 2025-09-01T21:38:06Z

types/bitbucket-definition.json

  "version_definition": {
-    "note": "The version is a commit or tag.",
+    "requirement": "required",
+    "note": "The version is an immutable commit hash (full or short) or a tag. Branch names (e.g., 'main') should not be used as they are mutable pointers.",


Makes sense. The original wording is simple enough and does not specify too little nor too much IMHO

pombredanne · 2025-09-01T22:02:54Z

types/bitbucket-definition.json

+    "pkg:bitbucket/birkenfeld/pygments-main@244fd47e07d1014f0aed9c",
+    "pkg:bitbucket/atlassian/[email protected]",
+    "pkg:bitbucket/atlassian/[email protected]#packages/analytics",


Good point, the pygments example should go since the project long moved to GitHub from Mercurial. ... for other examples too, let's use something real

maennchen · 2025-09-03T09:23:34Z

Needs to be rebased as of #640

Fixes for bitbucket

1c6505c

Signed-off-by: Prabhu Subramanian <[email protected]>

prabhu marked this pull request as draft August 24, 2025 20:16

matt-phylum reviewed Aug 25, 2025

View reviewed changes

pombredanne requested changes Sep 1, 2025

View reviewed changes

Fixes for bitbucket #627

Are you sure you want to change the base?

Fixes for bitbucket #627

Uh oh!

Conversation

prabhu commented Aug 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pombredanne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maennchen commented Sep 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants