Clean up icon mapping for default icons#34
Open
cloneofghosts wants to merge 5 commits intopacjo:mainfrom
Open
Conversation
Owner
|
Hi, I really appreciate the PR. Will take a look in the coming days, since I haven't touched the codebase in a while. |
Author
|
Noticed a few minor issues with the mapping which I've since fixed. As reference I was using the weather conditions from OpenWeatherMap as the basis for the mapping. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that the icon mapping isn't the best so I took a stab at updating it. I used OpenWeatherMaps condition codes as the basis which I assume these codes are based on.
#12 is caused by Breezy Weather sending code 803 instead of 804 so this PR won't fix that issue. It will change the icon to the Mostly Cloudy icon instead of the Partly Cloudy icon.
Fixes #33