ErrorGroups top errors#44
Open
kirillov6 wants to merge 2 commits into
Open
Conversation
forshev
approved these changes
May 13, 2026
| } | ||
| if req.Source != nil && *req.Source != "" { | ||
| subQ = subQ.Where(sq.Eq{"source": req.Source}).GroupBy("source") | ||
| aggTable, startDate := getHistData(req.Duration) |
Contributor
There was a problem hiding this comment.
GetErrorGroups got so big, maybe split cases with and without duration into separate functions?
Contributor
There was a problem hiding this comment.
or maybe even extract each db query
| } | ||
|
|
||
| if req.Duration != nil && *req.Duration != 0 { | ||
| aggTable, startDate := getHistData(req.Duration) |
Contributor
There was a problem hiding this comment.
maybe split this function also
| "github.com/ozontech/seq-ui/internal/app/types" | ||
| mock "github.com/ozontech/seq-ui/internal/pkg/repository_ch/mock" | ||
| "github.com/stretchr/testify/require" | ||
| "go.uber.org/mock/gomock" |
Contributor
There was a problem hiding this comment.
let's split imports into three groups like in other files
| "time" | ||
|
|
||
| mock "github.com/ozontech/seq-ui/internal/pkg/repository_ch/mock" | ||
| "go.uber.org/mock/gomock" |
Contributor
There was a problem hiding this comment.
let's split imports into three groups like in other files
| "github.com/ozontech/seq-ui/internal/app/types" | ||
| "github.com/ozontech/seq-ui/pkg/errorgroups/v1" | ||
| "github.com/ozontech/seq-ui/tracing" | ||
| "go.opentelemetry.io/otel/attribute" |
Contributor
There was a problem hiding this comment.
let's split imports into three groups like in other files
| WantErr bool | ||
| } | ||
|
|
||
| func DoTestHTTPEx[Treq, Tresp any](t *testing.T, data TestDataHTTPEx[Treq, Tresp]) { |
Contributor
There was a problem hiding this comment.
this is really nice change, tests got so much cleaner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
durationspecified