feat: migrate to thiserror#14
Draft
JarvisCraft wants to merge 1 commit into
Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JarvisCraft
force-pushed
the
thiserror
branch
2 times, most recently
from
3186d11 to
e32fec7
Compare
vadv
pushed a commit
that referenced
this pull request
May 12, 2026
Closes codex MED #14. run_fallback_round delegated to try_fallback_target per candidate, and try_fallback_target called resolved_startup_parameters() each time. A wave of N Patroni candidates therefore did N×{auth_query peek under DashMap shard read-lock, BTreeMap clone, size scan, overflow log + counter inc} for one client checkout - pure waste, since the cascade is host-independent. Resolve once at run_fallback_round entry and pass the borrowed map through race_wave to every try_fallback_target. Plain attempt and the optional sslmode=allow TLS retry both reuse the same map, so a config RELOAD landing between candidates still sees a coherent StartupMessage per round.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a (currently WIP) implementation of better-typed errors via
thiserror.Closed #13