helios/deploy: Wait for inventory collection #8650
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds another "wait for a thing to happen" loop in between waiting for the RSS -> Nexus handoff and waiting for all the zpools to show up. Attempting to query for the zpools fails if there hasn't been an inventory collection yet, so prior to this change we were racing. Fixes flake #8647.
iliana
approved these changes
Jul 22, 2025
| INVENTORY_COLLECTION_COUNT=$(pfexec zlogin oxz_switch /opt/oxide/omdb/bin/omdb db inventory collections list | wc -l) | ||
| until [[ "${INVENTORY_COLLECTION_COUNT}" -gt 1 ]]; do | ||
| if [[ $retry -gt 300 ]]; then | ||
| echo "Failed to handoff to Nexus after 300 seconds" |
There was a problem hiding this comment.
Suggested change
| echo "Failed to handoff to Nexus after 300 seconds" | |
| echo "Failed to wait for inventory collection after 300 seconds" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another "wait for a thing to happen" loop in between waiting for the RSS -> Nexus handoff and waiting for all the zpools to show up. Attempting to query for the zpools fails if there hasn't been an inventory collection yet, so prior to this change we were racing.
Fixes #8647.