[METADATA] Small correction - #158
Merged
Merged
Conversation
Ayoub-Farah
requested changes
Jul 30, 2026
Ayoub-Farah
left a comment
Ayoub-Farah
left a comment
Member
There was a problem hiding this comment.
I had a problem with the test file on windows, with mcumgr location not in the good format for windows.
Codex corrected the problem and generated the following python files :
PS C:\Users\afarahhass\Documents\Repo\CoreV2\Core_Luiz> & C:\Users\afarahhass\AppData\Local\Programs\Python\Python312\python.exe `
>> .\src\test_metadata_nvs.py --port COM29
Using board 58435001004B001B on port COM29
[1/8] Clearing all metadata fields...
CLEAR=OK
[2/8] Reading back (expect all fields empty/ERR)...
[3/8] Attempting undersized writes/reads (expect all rejected)...
FIELD EXPECTED ACTUAL RESULT
SPIN_SERIAL_BADSIZE -2 -2 OK
SHIELD_SERIAL_BADSIZE -2 -2 OK
SPIN_PASSWORD_BADSIZE -2 -2 OK
SHIELD_PASSWORD_BADSIZE -2 -2 OK
EXTRA_BADSIZE -2 -2 OK
[4/8] Reading back (expect fields still empty/ERR)...
[5/8] Checking free NVS space (baseline)...
FREE_SPACE=2008
[6/8] Writing canned test values...
[7/8] Reading back immediately (same-boot sanity check)...
FIELD WRITTEN READ RESULT
SPIN_SERIAL 'SPIN000000001' 'SPIN000000001' OK
SHIELD_SERIAL 'SHLD000000001' 'SHLD000000001' OK
SPIN_VERSION '9.9.9' '9.9.9' OK
SHIELD_VERSION '8.8.8' '8.8.8' OK
SPIN_PASSWORD 'SPINPASS01' 'SPINPASS01' OK
SHIELD_PASSWORD 'SHLDPASS01' 'SHLDPASS01' OK
EXTRA_0 'EXTRA0' 'EXTRA0' OK
EXTRA_1 'EXTRA1' 'EXTRA1' OK
EXTRA_2 'EXTRA2' 'EXTRA2' OK
EXTRA_3 'EXTRA3' 'EXTRA3' OK
EXTRA_4 'EXTRA4' 'EXTRA4' OK
[8/8] Resetting board and re-reading (persistence check)...
Done
FIELD WRITTEN READ RESULT
SPIN_SERIAL 'SPIN000000001' 'SPIN000000001' OK
SHIELD_SERIAL 'SHLD000000001' 'SHLD000000001' OK
SPIN_VERSION '9.9.9' '9.9.9' OK
SHIELD_VERSION '8.8.8' '8.8.8' OK
SPIN_PASSWORD 'SPINPASS01' 'SPINPASS01' OK
SHIELD_PASSWORD 'SHLDPASS01' 'SHLDPASS01' OK
EXTRA_0 'EXTRA0' 'EXTRA0' OK
EXTRA_1 'EXTRA1' 'EXTRA1' OK
EXTRA_2 'EXTRA2' 'EXTRA2' OK
EXTRA_3 'EXTRA3' 'EXTRA3' OK
EXTRA_4 'EXTRA4' 'EXTRA4' OK
PASS: values survived a board reset
[final] Checking free NVS space (post)...
FREE_SPACE=1800
ALL CHECKS PASSED
The test passed.
Member
|
Ok for me, we can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The password of the previous version only had 3 characters. That was an oversight. They should have 10.
PR description
This PR adds surpport for 10 character long passwords. It also adds a password for the SPIN board, which was not available before.
Testing
The PR was tested and passed with a SPIN board. Here's the result:
The test code can be found in the same repository and branch as before:
https://github.com/luizvilla/Core/tree/metaData