Skip to content

WIP: Truncate strings in sidebar#6533

Closed
dschmidt wants to merge 2 commits into
masterfrom
sidebar-truncate
Closed

WIP: Truncate strings in sidebar#6533
dschmidt wants to merge 2 commits into
masterfrom
sidebar-truncate

Conversation

@dschmidt
Copy link
Copy Markdown
Member

@dschmidt dschmidt commented Mar 4, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

Long usernames are unusable in the people tab of the sidebar.

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • make RecipientContainer not expand beyond selected-option-container of oc-select (InviteCollaboratorForm.vue)
    Screenshot_20220307_133742

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Mar 4, 2022

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/23299/55/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:98

@dschmidt dschmidt mentioned this pull request Mar 7, 2022
Closed
@AlexAndBear
Copy link
Copy Markdown
Contributor

AlexAndBear commented May 17, 2022

taken care of in #6984

@AlexAndBear AlexAndBear mentioned this pull request May 17, 2022
Merged
10 tasks
@dschmidt
Copy link
Copy Markdown
Member Author

dschmidt commented May 24, 2022

Fixed in #6984

@dschmidt dschmidt closed this May 24, 2022
@pascalwengerter pascalwengerter deleted the sidebar-truncate branch July 5, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees

@pascalwengerter pascalwengerter

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Components in the taskbar are hidden

4 participants

@dschmidt @ownclouders @AlexAndBear @pascalwengerter