[WIP] Integrate OAuth2/OIDC logout on bookmark deletion #1478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Call deauthenticateConnection before erasing vault when deleting bookmarks - Ensures proper logout at IdP level (token revocation/OIDC end session) - Maintains user-friendly behavior: deletion proceeds even if logout fails - Update SDK submodule to include logout support 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates OAuth2/OIDC logout functionality into the bookmark deletion flow. When users delete a bookmark (or "log out" in branded builds), the app now properly logs out from the identity provider before removing local data.
Changes
OCBookmarkManager+Management.swiftto calldeauthenticateConnectionduring bookmark deletionperformVaultErasureRelated Issue
Currently no issue exists for this feature. This addresses the inconsistency where iOS app users remained logged in at the IdP level after removing bookmarks.
Motivation and Context
Users expect that removing an account from the app also logs them out from the server. The current behavior only removes local data, leaving active sessions on the identity provider. This PR brings the iOS app in line with the web client's logout behavior.
How Has This Been Tested?
Screenshots (if appropriate):
N/A - Uses existing deletion UI
Types of changes
Checklist: