ci: automatically generate release notes and build dist only on release #121
Conversation
|
By building |
How so? changelogen makes the commit |
It will be possible to attach only the release version and not the version of any commit |
|
I very much doubt that there are people who attach the hash of a particular commit and not the commit of the new version But if necessary, I can undo this change |
|
@xhyrom So should I make |
They exist; in fact, even github recommends it - https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#:~:text=Pin%20actions%20to%20a%20full%20length%20commit%20SHA
That's already done by |
I know, but I'm talking about completely different
I will then rewrite it so that it commits on behalf of the bot, and I will remove the formatting and build step from the release workflow |
Can you tell me what are you talking about? I thought we had discussion about using commit sha as action version. |
I and everyone else pin the hash of the commit to GitHub Actions (or rather Renovate does this) For example As you can see, the comment on the right shows the version of action that is used here, and therefore the hash of the commit, this is the commit on which the release was created If I need to attach to some other commit, I will change its hash But I have not yet seen such cases where it is necessary to attach to a specific commit other than the release commit |
|
@xhyrom I already updated the autofix.ci workflow and now it will commit on behalf of the bot |
|
Can you resolve conflicts? |
Yep but later |
Done! |
One more time please 😅 |
Im done |
There was a problem hiding this comment.
We should ensure code is formatted on every commit —not just before releases. Relying on formatting and building only at release time leads to inconsistencies and breaks the ability to use any commit hash as a action version.
I think there's currently no better way than using autofix.
xhyrom
changed the title
I know solution but wait please |
In order to ensure that the code is formatted at each stage, we can lint each commit For example, someone created a PR, and on some commit the author did not format the code - CI will lint it and report an error But then you have to manually fix the formatting errors If necessary, we can do this with autofix.ci I'll do it now. |
It is better to build
distand format files only before release in order not to spam with commits and unnecessary changesI also added automatic generation of release notes with
changelogen, when the Release Workflow starts it will automatically write the release notes, commit all the changes, run them and create a new release with a new version according to the changes made thanks to Conventional Commits