File rep error classification issues - #317
Merged
Merged
Conversation
Every exception a semantic action raises that is not a LanguageError is reported as a specification_error, which exits the interpreter and then plcc-rep. One bad input ends the session, and the user is told to fix a specification that is not at fault. Reported from downstream, where it was found porting a course language suite. The reproduction is a self-contained 14-line spec built against plcc-ng alone, verified on 2.0.2 across the Python, Java, and JavaScript targets. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
… error Exhausting the target runtime's call stack reaches the same non-LanguageError branch as issue 190 and is labeled a specification error, advising the user to edit a grammar that is not at fault. Filed separately because the remedy may differ: continuing the session after a stack overflow is a real question, where for 190 it is clearly correct. Includes the downstream port's measured ceilings across the three targets, which differ about eightfold between Python and the other two. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s internal issue tracker (in dev-docs/) to record and surface two newly filed plcc-rep error-classification problems, ensuring they appear in the Roadmap and that the issue ID counter advances correctly.
Changes:
- Added issue #190 documenting that non-
LanguageErrorexceptions terminateplcc-repsessions and are misclassified asspecification_error. - Added issue #191 documenting that interpreter resource exhaustion (e.g., recursion/stack overflow) is also misclassified as
specification_error. - Updated
dev-docs/roadmap.mdand bumpeddev-docs/issues/.next-id.txtto reflect the new issues.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dev-docs/roadmap.md | Adds roadmap entries for issues #190 and #191 under the Fix section. |
| dev-docs/issues/190-rep-kills-session-on-program-errors.md | New issue documenting session termination + misclassification for program errors. |
| dev-docs/issues/191-rep-reports-resource-exhaustion-as-specification-error.md | New issue documenting misclassification for interpreter resource exhaustion. |
| dev-docs/issues/.next-id.txt | Advances next issue ID to 192 after adding #190 and #191. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The authors of this PR...