File upstream issues from languages ng - #315
Merged
Merged
Conversation
…port Migrated from the languages-ng repo's dev-docs/issues, where they were filed with `target: ourPLCC/plcc-ng` and held pending go-ahead. Rewritten from this repo's perspective and re-verified against current src/ rather than the installed CLI: - 185 plcc-rep parses each SOURCE independently (docs) - 186 plcc-rep deadlocks on a partial stdout line (fix) - 187 plcc-rep lacks output and clean-exit record kinds (feat) - 188 FOLLOW set omits the nullable tail (fix) The other four upstream-targeted issues in that repo (003, 004, 006, 010) already landed here as 162, 163, 164, and 174. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The languages-ng issue system is a fork of this one that diverged in three ways: issues never move (a `closed:` frontmatter date is the status), YAML frontmatter replaces the `**Type:**`/`**Date:**` headers, and a `target:` field names the repo an issue is about. The first is the load-bearing one. Closing by `git mv` into done/ means every link written before a close goes stale; #149 cleaned that up once and #150 built rewriting into close.bash to stop it recurring, but 14 links under issues/done/ are broken today. Both remaining shapes are structural: a link rewritten correctly at close time breaks when the issue it points *at* closes later, and the blanket depth rewrite cannot distinguish an already-wrong relative path from a right one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a batch of newly discovered/upstreamed issues (ported from languages-ng) into this repo’s dev-docs/issues/ tracking system and updates the roadmap and ID allocator accordingly, so the findings are visible in the canonical “Open Issues” list and future issue creation continues with the correct next ID.
Changes:
- Add new issue writeups #185–#189 covering
plcc-repbehavior/protocol gaps, an LL(1) FOLLOW-set bug, and an issue-system alignment proposal. - Update
dev-docs/roadmap.mdto list the newly filed issues under the appropriate sections (Fix/Feat/Docs/Chore). - Advance
dev-docs/issues/.next-id.txtto the next available issue ID.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dev-docs/roadmap.md | Adds roadmap entries for issues #185–#189 under the correct category headings. |
| dev-docs/issues/.next-id.txt | Advances the next-issue counter to 190 after filing #185–#189. |
| dev-docs/issues/185-rep-parses-each-source-independently.md | Documents the plcc-rep per-SOURCE parsing behavior difference vs old PLCC and suggests migration-guide updates. |
| dev-docs/issues/186-rep-deadlocks-on-partial-stdout-line.md | Records a concrete deadlock failure mode in plcc-rep when semantic actions write partial stdout lines. |
| dev-docs/issues/187-rep-lacks-output-and-clean-exit-records.md | Proposes protocol-level record kinds to support user output and clean session termination in plcc-rep. |
| dev-docs/issues/188-follow-set-omits-nullable-tail.md | Captures a specific FOLLOW-set under-approximation bug and includes a suggested algorithmic fix and test idea. |
| dev-docs/issues/189-align-issue-system-with-languages-ng.md | Proposes adopting languages-ng’s “issues never move; status in frontmatter” approach to avoid link breakage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The authors of this PR...