Worktree close issue 022 - #15
Merged
Merged
Conversation
Checked ourPLCC/plcc-ng at 48fb1a5 (v2.0.2): #185, #186, and #187 are all still open there, in dev-docs/issues/ rather than done/, still listed under Open Issues in that repo's roadmap, with no branch working any of them. Records that state in each of the three local issues, since nothing else in this repository carries it and a status check that is not committed is a status check that has to be redone. For 36, notes that upstream split the report: #186's bounded-read fix does not depend on #187's record kinds and can land first, improving the failure mode from a silent hang to a diagnostic without letting OBJ drop its buffering workaround. For 37, notes that it is #187 specifically that unblocks the revert. For 22, replaces the stays-open condition with the reasoning for closing it: the half of that condition that belongs to this repository is satisfied, and the half that remains is a documentation task upstream. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ly), update roadmap Nothing in this repository is outstanding. The issue's own closing condition had two halves: upstream lands a fix or migration-guide entry, and V6's two-file Prog/p1 + Prog/p2 example either works or is documented as needing cat. The second half has been satisfied since the V6 port -- the entry is in course-material-impact.md under ## V6, naming this issue -- and the first is a documentation task in ourPLCC/plcc-ng, tracked there as its issue #185. No src/ change is pending and no workaround is carried, so an open issue here overstated what was outstanding. If upstream later decides plcc-rep should join its sources, that arrives as a behavior change in a plcc-ng release and wants a fresh issue. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Closes local tracking issue #022 (which documented plcc-rep’s per-SOURCE parsing behavior) now that the classroom-facing workaround is already documented in this repo and the remaining work is purely upstream documentation.
Changes:
- Remove issue #22 from the
dev-docs/roadmap.mdOpen Issues list. - Mark
dev-docs/issues/022-...as closed and add closure rationale tying it to the existing course-material impact entry. - Add “upstream status checked” notes to issues #036 and #037 for current tracking clarity.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dev-docs/roadmap.md | Removes the #22 entry from Open Issues to reflect closure. |
| dev-docs/issues/022-plcc-rep-parses-each-source-independently.md | Sets closed: date and documents why the issue is closed despite upstream still being open. |
| dev-docs/issues/036-plcc-rep-deadlocks-on-partial-stdout-line.md | Adds an upstream status verification note (checked date + upstream state). |
| dev-docs/issues/037-plcc-rep-lacks-output-and-clean-exit-records.md | Adds an upstream status verification note (checked date + upstream state). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#22 (internal) get's closed. Nothing in this repository was outstanding — the issue's closing condition had a local half (V6's two-file example documented as needing cat) that has been satisfied since the V6 port, and an upstream half that is a documentation task in ourPLCC/plcc-ng #185.
Also records the 2026-08-13 upstream status check in #22, #36, and #37: plcc-ng #185, #186, and #187 are all still open at 48fb1a5 (v2.0.2).
Docs only, no src/ changes. bin/issues/check.bash green (17 open, 32 closed); bin/tests/issues-list.bats 8/8.