feat(guidelines): clarify representation of multiple values for query parameters#102
feat(guidelines): clarify representation of multiple values for query parameters#102plemech23 wants to merge 1 commit intootto-de:mainfrom
Conversation
|
@plemech23 Wie es aussieht, kann ich mich in diesem Repo nicht selbst als Reviewer auswählen (und auch sonst keine Reviewer auswählen). Kannst du mich bitte hinzufügen oder muss das jemand anderes tun? |
|
@plemech23 Are you planning to have this be reviewed & approved by another tech colleague from the community? (4-eyes principle) |
|
@plemech23 I looked at this PR several times and to be honest, I'm confused. To me, it looks like you not only added an example but also changed the wording of the actual guideline. Can you please clarify: Is there an actual change as to what the provider needs to do? |
Sure, @maxedenharter0507 @jensfischer1515 @kiriakos could one of you please review it? |
Yes, I’ve reworded it a bit to make it clearer and add the OAS example. Should I adjust the PR body or the rule itself? |
|
@plemech23 It depends :) |
|
@kollegolin Has a point. The PR does is tighten up the language around the original intent of the rule as well as provide an illustrative example. The Changelog entry could reflect that first part to reduce the "surprise" factor I guess. @plemech23 how about |
@plemech23 , @kiriakos I'm not sure we even need that whole rewording part ("tighten the language") as that leads to confusion. If we only want to provide an example, let's stick to that in the guideline. Happy to have a pairing call on the topic. |

Changelog:
Update