[fix] メニューバー表示を AppKit 化して前景色切り替えを修正#8
Open
yaggy438 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
メニューバーアイコンの表示が黒固定だったため、他のメニューバーアイコンと同様に、壁紙の明暗に応じて白/黒で動的に切り替わるよう変更しました。
実現のため、
MenuBarExtraの SwiftUI label からNSStatusItem+ AppKit 描画に変更しています。変更内容
StatusItemControllerで管理するように変更StatusItemImageRendererでNSImageとして描画NSStatusBarButtonの状態と appearance から前景色を決定MenuBarLabelを削除確認
./Scripts/build.sh --installが通ることを確認しました