メニューバーアイコンのダーク/ライトモード視認性を修正#14
Open
OkamotoYuito wants to merge 1 commit into
Open
Conversation
ImageRenderer がシステム外観を引き継がない問題により、ダークモードのメニューバーで アイコンが黒く描画されて見えなくなっていた。 - NSApp.effectiveAppearance でモードを判定し、colorScheme を明示的に注入 - 半透明カプセル背景を追加（ダーク: 黒0.25、ライト: 白0.55）して デスクトップ背景の透過によるコントラスト低下にも対応
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
ImageRendererがシステム外観を引き継がない問題により、ダークモードのメニューバーでアイコンが黒く描画されて見えなくなっていた変更内容
NSApp.effectiveAppearanceでダーク/ライトモードを判定し、colorSchemeをImageRendererに明示的に注入確認方法