Skip to content

Conversation

TrueRou
Copy link
Contributor

@TrueRou TrueRou commented Jul 11, 2025

Describe your changes

tourney client can't connect to bancho due to old clients, as https://osu.ppy.sh/api/v2/changelog?stream=tourney has an empty builds list.

in fact, tourney client use the same channel as the its base osu stream(stable).

Related Issues / Projects

Checklist

  • I've manually tested my code

@7ez
Copy link
Contributor

7ez commented Jul 11, 2025

I'm pretty sure you can use tourney on cutting-edge too, no?

@TrueRou
Copy link
Contributor Author

TrueRou commented Jul 12, 2025

I'm pretty sure you can use tourney on cutting-edge too, no?

After testing, sure it can.

The sent "v" was like b20250702tourney, so we might have to join stable and cutting-edge builds on tourney channels checking, as we can't distinguish between them by "v"

@arily
Copy link
Contributor

arily commented Jul 23, 2025

I have another related question,

    if osu_version.stream is OsuStream.TOURNEY and not (
        user_info["priv"] & Privileges.DONATOR
        and user_info["priv"] & Privileges.UNRESTRICTED
    ):
        # trying to use tourney client with insufficient privileges.
        return {
            "osu_token": "no",
            "response_body": app.packets.login_reply(
                LoginFailureReason.AUTHENTICATION_FAILED,
            ),
        }

(

if osu_version.stream is OsuStream.TOURNEY and not (
)
shouldn't TOURNEY_MANAGER be given access to tourney client as well?

@arily
Copy link
Contributor

arily commented Jul 24, 2025

I have another related question,

    if osu_version.stream is OsuStream.TOURNEY and not (
        user_info["priv"] & Privileges.DONATOR
        and user_info["priv"] & Privileges.UNRESTRICTED
    ):
        # trying to use tourney client with insufficient privileges.
        return {
            "osu_token": "no",
            "response_body": app.packets.login_reply(
                LoginFailureReason.AUTHENTICATION_FAILED,
            ),
        }

(

if osu_version.stream is OsuStream.TOURNEY and not (

)
shouldn't TOURNEY_MANAGER be given access to tourney client as well?

ppy-sb#10

@mayacopeland
Copy link
Contributor

mayacopeland commented Jul 24, 2025

nevermind

allow tourney manager login use tourney client
osu_stream_strs.append("stable40")
osu_stream_strs.append("cuttingedge")

for osu_stream_str in osu_stream_strs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i very much disagree with doing a request in a for loop here, why are we not just requesting OSU_API_V2_CHANGELOG_URL, iterating over the streams and getting dates from the latest_build?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, looking at the current response i can't seem to see anything about major versions anymore

Copy link
Member

@NiceAesth NiceAesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants