Fix multistage timestep boundary error causing training crashes #519
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical bug in multistage training (e.g., Wan 2.2 LoRAs) that causes training to crash with
RuntimeError: element 0 of tensors does not require grad and does not have a grad_fnwhen timesteps land at or slightly beyond the boundary value due to floating point precision.The Problem
When training multistage models like Wan 2.2 with separate high/low noise experts:
The Fix
After converting timestep indices to actual timestep values (line 1267), the fix adds clamping to ensure timesteps stay strictly within the multistage boundary range:
For low noise training (boundary 0.0-0.9), timesteps are now clamped to [0, 899.99] max.
Testing
Related Issues
This may be related to other reports of training crashes during multistage LoRA training with similar error messages.
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]