Feat - Included docker-scan for the images #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jordan-wright
left a comment
jordan-wright
left a comment
There was a problem hiding this comment.
This seems reasonable to me! Left a couple of comments for consideration.
| push: | ||
| pull_request: | ||
| schedule: | ||
| - cron: '0 0 * * 1' |
Contributor
There was a problem hiding this comment.
Just a heads up, this appears to run at midnight every Monday - is that what you're looking to do?
| docker build -t docker.pkg.github.com/ossf/package-feeds:${{ github.sha }} . | ||
|
|
||
| - name: Run Trivy vulnerability scanner | ||
| uses: aquasecurity/trivy-action@master |
Contributor
There was a problem hiding this comment.
Can we pin this to a version or commit? It's my understanding that using actions from master isn't really recommended, if possible (even though this particular one looks lower risk).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker scan for the image.