fix: android library ppp #5450
fix: android library ppp #5450
Conversation
|
Only issue for this PR is related to DCO (please add a |
|
@EternalDreamer01 do you want to add a sign-off line to your commits so this could be merged? Just in case - you simply need to add the |
|
I see some unrelated stuff crept in when adding the sign-off, and was later removed - the trouble is, the DCO check looks at every commit in the PR, so it now wants all of them to be signed off 🤦 😃 You can get more details in the check run here: https://github.com/ossf/cve-bin-tool/pull/5450/checks?check_run_id=59601378869, but in essence you can probably just squash all of the commits and force-push the PR branch so that you have only one commit, that's signed off. That should do it. |
Signed-off-by: Eternal Dreamer <[email protected]>
Add playwright.download.prss.microsoft.com and cdn.playwright.dev in allowed-endpoints to fix the following failure when installing playwright: Downloading Chromium 143.0.7499.4 (playwright build v1200) from https://cdn.playwright.dev/dbazure/download/playwright/builds/chromium/1200/chromium-linux.zip (node:3714) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities. (Use `node --trace-deprecation ...` to show where the warning was created) Error: connect ECONNREFUSED 54.185.253.63:443 at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1637:16) { errno: -111, code: 'ECONNREFUSED', syscall: 'connect', address: '54.185.253.63', port: 443 } Also add v4.mirror.cveb.in:443 to fix the same kind of issue: ClientConnectorError: Cannot connect to host v4.mirror.cveb.in:443 ssl:default [Connect call failed ('54.185.253.63', 443)] All those issues are probably raised because ubuntu-latest is used instead of intel-ubuntu-latest since switch to ossf Signed-off-by: Fabrice Fontaine <[email protected]> Signed-off-by: Eternal Dreamer <[email protected]>
https://nvd.nist.gov/vuln/detail/cve-2025-40939 has the following configurations: [{}] This will result in a crash as current code wrongly assumes that all configuration object has a nodes parameter Signed-off-by: Fabrice Fontaine <[email protected]> Signed-off-by: Eternal Dreamer <[email protected]>
Obviously, --import-json is mainly useful when db doesn't exist so drop
cvedb_orig.check_db_exists() from if statement
Moreover, do not exit after --import-json or --export-json to be
consistent with --import and --export
Finally, while at it, add --{im,ex}port-json to offline.md
Signed-off-by: Fabrice Fontaine <[email protected]>
Signed-off-by: Eternal Dreamer <[email protected]>
Remove conditional logic for Intel runners since the repo has moved to ossf. All workflows now use 'ubuntu-latest' directly. Fixes ossf#5452 Signed-off-by: Jack <[email protected]> Signed-off-by: Jack Lau <[email protected]> Signed-off-by: Eternal Dreamer <[email protected]>
Signed-off-by: Eternal Dreamer <[email protected]>
Signed-off-by: Eternal Dreamer <[email protected]>
…e pattern Signed-off-by: Eternal Dreamer <[email protected]>
Signed-off-by: Eternal Dreamer <[email protected]>
Signed-off-by: Eternal Dreamer <[email protected]>
Signed-off-by: Eternal Dreamer <[email protected]>
Signed-off-by: Dimitri Simon <[email protected]> Signed-off-by: Eternal Dreamer <[email protected]>
Signed-off-by: Dimitri Simon <[email protected]> Signed-off-by: Eternal Dreamer <[email protected]>
Signed-off-by: Dimitri Simon <[email protected]> Signed-off-by: Eternal Dreamer <[email protected]>
Signed-off-by: Dimitri Simon <[email protected]> Signed-off-by: Eternal Dreamer <[email protected]>
|
Let me know if something is still wrong, |
|
Well, the DCO check is happy now that you've signed off all the commits, but the commits themselves are somewhat different, so they don't cancel out and there are changes beyond the intended piece. You may want to either create a new branch from scratch, off of |
4 participants
I've messed up the things in #5444, so I'm opening this new PR ;
Fix PPP on Android devices #5441