server: Avoid overwriting log fields in adj table #3242
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not provide peer-specific logger when creating adj table, but use parent logger instead. Peer-specific logger contains "Topic" and "Key" log fields, which are also set when logging table events, but with different values. This is unnecessary and can be even deemed invalid in more strict logging setups. Signed-off-by: Rastislav Szabo <[email protected]>
Member
|
make sense, pushed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not provide peer-specific logger when creating adj table, but use parent logger instead.
Peer-specific logger contains "Topic" and "Key" log fields, which are also set when logging table events, but with different values. This is unnecessary and can be even deemed invalid in more strict logging setups.
(This was detected by the CI in Cilium, and seems to be the only occurrence of log fields overwrite in the GoBGP codebase)