server: default to global RIB when policy name is empty #3233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the name parameter is empty in toPolicyInfo(), use GLOBAL_RIB_NAME as the default instead of returning an error. This makes the behavior consistent with other APIs throughout the codebase where an empty string conventionally represents the global RIB. Signed-off-by: FUJITA Tomonori <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the name parameter is empty in toPolicyInfo(), use GLOBAL_RIB_NAME as the default instead of returning an error. This makes the behavior consistent with other APIs throughout the codebase where an empty string conventionally represents the global RIB.